CMS 2
Code Reviews
Gerald Senarclens de Grancy
,
cms2@senarclens.eu
Useful Code Reviews
Purpose of code reviews
Sharing knowledge
Establishing common coding guidelines
Creating a feeling of collective code ownership
Don't look for errors
Try to learn and understand the code
Be gentle
Comments should be constructive
Assign roles
Roles could be a focus on documentation, functionality, correctness, performance, ...
Don't let seniority get in the way
Involve newbies and experts
Fresh perspectives
Learning by a transfer of experience and knowledge
Use a coding standard
Formatting discussions should not get in the way of reviews
Reviews should be fun
Eg. brown-bag lunch
Mattias Karlsson in [Henney (2010), pg 28f]